Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup icons #3871

Merged
merged 4 commits into from
May 12, 2023
Merged

Cleanup icons #3871

merged 4 commits into from
May 12, 2023

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented May 11, 2023 •
edited
Loading

1/4 main <= this <= #3872 <= #3873 <= #3874

First task of #3848

  • Removed icons from the icons folder if they were inside of the Codicons folder.
  • Renamed icons with different names in Codeicons

Closes #3848 when everything is merged back

@sroy3 sroy3 self-assigned this May 11, 2023
@sroy3 sroy3 marked this pull request as ready for review May 11, 2023 17:22
@sroy3 sroy3 requested review from mattseddon and julieg18 as code owners May 11, 2023 17:22
This was referenced May 11, 2023
Closed
Merged
Merged
Merged
julieg18
julieg18 approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@sroy3
Read and transform svg icons from list (#3872)
46cba7e 
* Read and transform svg icons from list

* Apply review comments

* Automatically add new icons to the icons story in Storybook (#3873)

* Automatically add new icons to the icons story in Storybook

* Add available codicons to Storybook (#3874)
@codeclimate
Copy link

codeclimate bot commented May 12, 2023

Code Climate has analyzed commit 46cba7e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 94.9% (0.0% change).

View more on Code Climate.

@sroy3
Copy link
Contributor Author

sroy3 commented May 12, 2023

@mattseddon I'll go ahead and merge this as this is housekeeping stuff, but I'll be happy to do any follow-up/modification if you want to review this.

@sroy3 sroy3 merged commit 520c213 into main May 12, 2023
@sroy3 sroy3 deleted the icons-cleanup branch May 12, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattseddon mattseddon Awaiting requested review from mattseddon mattseddon is a code owner

@julieg18 julieg18 Awaiting requested review from julieg18

Assignees

@sroy3 sroy3

Labels
🏠 housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review how we use SVGs (icons)
2 participants
@sroy3 @julieg18