Add Remotes section to setup webview #3901
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
webview/src/shared/components/sectionContainer/SectionContainer.tsx
Outdated
Show resolved
Hide resolved
mattseddon
force-pushed
the
add-remotes-section
branch
from
592bcec to
cf29462
Compare
mattseddon
force-pushed
the
add-remotes-section
branch
from
f3b9910 to
288b3dc
Compare
mattseddon
changed the title
| state, | ||
| action: PayloadAction< | ||
| | { [dvcRoot: string]: { [alias: string]: string } | undefined } | ||
| | undefined |
| Object.entries(remotes).map(([alias, remote], i) => ( | ||
| <tr key={[alias, remote].join('-')}> | ||
| {i === 0 ? <td className={styles.alias}>{dvcRoot}</td> : <td />} | ||
| <td className={styles.alias}>{alias}</td> |
There was a problem hiding this comment.
Unrelated to this pr, but we also should be using th in the dvc env details table. I'll open a quick pr later correcting that :)
| <tbody> | ||
| {Object.entries(remotes).map(([alias, remote]) => ( | ||
| <tr key={[alias, remote].join('-')}> | ||
| <td className={styles.alias}>{alias}</td> |
There was a problem hiding this comment.
Same comment here about using a th instead of a td
| expect(setupDVCButton).toBeVisible() | ||
| }) | ||
|
|
||
| it('should show the list of remotes there is only one project in the workspace', () => { |
There was a problem hiding this comment.
Should this be:
| it('should show the list of remotes there is only one project in the workspace', () => { | |
| it('should show the list of remotes if there is only one project in the workspace', () => { |
| Object.entries(remotes).map(([alias, remote], i) => ( | ||
| <tr key={[alias, remote].join('-')}> | ||
| {i === 0 ? <td className={styles.alias}>{dvcRoot}</td> : <td />} | ||
| <td className={styles.alias}>{alias}</td> |
There was a problem hiding this comment.
Unrelated to this pr, but we also should be using th in the dvc env details table. I'll open a quick pr later correcting that :)
| remoteList: NonNullable<RemoteList> | ||
| }> = ({ remoteList }) => ( | ||
| <table data-testid="remote-details" className={styles.remoteDetails}> | ||
| <tbody> |
There was a problem hiding this comment.
Minor, but we technically don't need this tbody in the table since a tbody is only needed if table has thead, tfoot or multiple tbodys. We also have an unneeded tbody in dvc env table... I'll change that :)
| import { SetupSection } from 'dvc/src/setup/webview/contract' | ||
| import { updateSectionCollapsed } from '../../state/webviewSlice' | ||
|
|
||
| const getAllSections = (collaspsed: boolean) => ({ |
There was a problem hiding this comment.
Great work on the shared functions and components!
mattseddon
force-pushed
the
add-remotes-section
branch
from
288b3dc to
4093a8d
Compare
|
Code Climate has analyzed commit ace9c69 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 99.1% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.0% (0.0% change). View more on Code Climate. |
2/3
main<- #3908 <- this <- #3912First basic step for #3867.
Demo
Screen.Recording.2023-05-17.at.6.15.07.pm.mov
See storybook for how workspaces with multiple projects are handled.