Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of show experiments command for setup page #3910

Merged
merged 1 commit into from
May 17, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented May 17, 2023

Closes #3909

This PR wires up the dvc.showExperiments command with the "Show Experiments" button in the setup webview to get around there being multiple DVC projects within the workspace.

Demo

Screen.Recording.2023-05-17.at.11.46.44.am.mov

@mattseddon mattseddon self-assigned this May 17, 2023
@mattseddon mattseddon marked this pull request as ready for review May 17, 2023 02:32
@mattseddon mattseddon requested review from sroy3 and julieg18 as code owners May 17, 2023 02:32
@mattseddon mattseddon force-pushed the wire-up-show-experiments branch from bdc5950 to d460ec4 Compare May 17, 2023 21:28
@mattseddon mattseddon enabled auto-merge (squash) May 17, 2023 21:28
@codeclimate
Copy link

codeclimate bot commented May 17, 2023

Code Climate has analyzed commit d460ec4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.0% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 4f37e63 into main May 17, 2023
@mattseddon mattseddon deleted the wire-up-show-experiments branch May 17, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add project selector to Setup webview when there are multiple DVC projects in the VS Code workspace
3 participants