Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Get Started" section to Setup #3943

Merged
merged 5 commits into from
May 22, 2023
Merged

Add "Get Started" section to Setup #3943

merged 5 commits into from
May 22, 2023

Conversation

julieg18
Copy link
Contributor

  • A start to adding a "Get Started" section. Currently, it's essentially just a reference to our walkthrough.

Demo

image

Part of #3434

@julieg18 julieg18 added the product PR that affects product label May 19, 2023
@julieg18 julieg18 self-assigned this May 19, 2023
julieg18
julieg18 commented May 19, 2023
View reviewed changes
webview/src/setup/components/GetStarted.tsx
New to the extension? Go through the walkthrough to familiarize yourself
with the different features.
</p>
<Button onClick={showWalkthrough} text="Show Walkthrough" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the things that we've discussed when it comes to this section is avoiding circular references. Aka, user goes to the setup, clicks on "Show Walkthrough", sees first step is "Install DVC", clicks on "Setup", then gets taken right back to setup.

Currently, I don't think it feels broken since the walkthrough setup links take you to a different section with the other sections closed so we could, if everyone else agrees, merge as is.

I've posted ideas for the next steps in #3434 if anyone would like to join in the discussion :)

#3434 (comment)

@julieg18 julieg18 marked this pull request as ready for review May 19, 2023 17:17
@julieg18 julieg18 requested review from mattseddon and sroy3 as code owners May 19, 2023 17:17
@julieg18 julieg18 requested a review from shcheklein May 19, 2023 17:19
@julieg18 julieg18 enabled auto-merge (squash) May 22, 2023 14:45
@codeclimate
Copy link

codeclimate bot commented May 22, 2023

Code Climate has analyzed commit f7836a0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.0% (0.0% change).

View more on Code Climate.

@julieg18 julieg18 merged commit 5420240 into main May 22, 2023
@julieg18 julieg18 deleted the add-get-started-section branch May 22, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattseddon mattseddon mattseddon approved these changes

@sroy3 sroy3 Awaiting requested review from sroy3

@shcheklein shcheklein Awaiting requested review from shcheklein shcheklein is a code owner

Assignees

@julieg18 julieg18

Labels
product PR that affects product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julieg18 @mattseddon