Fix issues with messages from the plots webview #3986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
May 26, 2023
| return commands.executeCommand(RegisteredCommands.PLOTS_CUSTOM_ADD) | ||
| return commands.executeCommand( | ||
| RegisteredCommands.PLOTS_CUSTOM_ADD, | ||
| this.dvcRoot |
There was a problem hiding this comment.
[F] If there were multiple dvc projects in the workspace then clicking on the add custom plot button in the webview would have prompted the user for which project they wanted to run the add command against.
mattseddon
commented
May 26, 2023
| case MessageFromWebviewType.REFRESH_REVISIONS: | ||
| return this.refreshData() | ||
| return commands.executeCommand( | ||
| RegisteredCommands.PLOTS_REFRESH, |
There was a problem hiding this comment.
[F] We had code and an extra command in here that was really duplicating logic unnecessarily.
mattseddon
force-pushed
the
fix-plot-commands
branch
2 times, most recently
from
1706238 to
1879d27
Compare
sroy3
approved these changes
May 26, 2023
mattseddon
force-pushed
the
fix-plot-commands
branch
from
1879d27 to
b152528
Compare
|
Code Climate has analyzed commit b152528 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of small issues with messages coming from the plots webview. Comments inline.