-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to show applicable extension for each storage provider #4004
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import React from 'react' | ||
import styles from './styles.module.scss' | ||
import { Icon } from '../../../shared/components/Icon' | ||
import { Extensions } from '../../../shared/components/icons' | ||
|
||
export const ShowExtension: React.FC<{ id: string; name: string }> = ({ | ||
id, | ||
name | ||
}) => { | ||
const idQuery = `"@id:${id}"` | ||
|
||
return ( | ||
<p> | ||
<Icon | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With this admonition added, there are now 2-3 admonitions stacked up on top of each other in each panel: This feels hard to read for me but I'm not really seeing an alternative solution besides rewording these into paragraphs instead of admonitions which might not actually make these more readable 🤔 |
||
icon={Extensions} | ||
width={16} | ||
height={16} | ||
className={styles.infoIcon} | ||
/>{' '} | ||
View the{' '} | ||
<a | ||
href={`command:workbench.extensions.search?${encodeURIComponent( | ||
idQuery | ||
)}`} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [F] This took a long time to workout. I actually had to visit the VS Code codebase to copy the expected format. Finally found the format at |
||
> | ||
{name} | ||
</a>{' '} | ||
extension. | ||
</p> | ||
) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import * as React from 'react' | ||
import type { SVGProps } from 'react' | ||
const Extensions = (props: SVGProps<SVGSVGElement>) => ( | ||
<svg | ||
width={24} | ||
height={24} | ||
viewBox="0 0 24 24" | ||
xmlns="http://www.w3.org/2000/svg" | ||
fill="currentColor" | ||
{...props} | ||
> | ||
<path | ||
fillRule="evenodd" | ||
clipRule="evenodd" | ||
d="M13.5 1.5L15 0h7.5L24 1.5V9l-1.5 1.5H15L13.5 9V1.5zm1.5 0V9h7.5V1.5H15zM0 15V6l1.5-1.5H9L10.5 6v7.5H18l1.5 1.5v7.5L18 24H1.5L0 22.5V15zm9-1.5V6H1.5v7.5H9zM9 15H1.5v7.5H9V15zm1.5 7.5H18V15h-7.5v7.5z" | ||
/> | ||
</svg> | ||
) | ||
export default Extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's just me as a pretty literal person, but a sentence telling me about the separate extension felt confusing. Do I need this extension to setup DVC remotes? Looking at the comment you linked in #3867, I'm assuming the purpose is to let the user know that installing the corresponding remote extension would make remote setup easier 🤔
Maybe we could make that reasoning more clear? For example,
Make setup easier with the Azure Storage extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without doing some due diligence I wouldn't make that claim. I am going to see if those extensions expose useful APIs but for now I just wanted to make people aware that they exist.