Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "(pip)" to setup install button #4013

Merged
merged 3 commits into from
May 31, 2023
Merged

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented May 30, 2023

Demo

image

Start to #3935

@@ -98,8 +98,8 @@ CompletedConnected.args = getUpdatedArgs({
shareLiveToStudio: true
})

export const NoCLIPythonNotFound = Template.bind({})
NoCLIPythonNotFound.args = getUpdatedArgs({
export const CLIPythonNotFound = Template.bind({})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this typo while looking at storybook.

@julieg18 julieg18 marked this pull request as ready for review May 30, 2023 23:25
@julieg18 julieg18 requested review from mattseddon and sroy3 as code owners May 30, 2023 23:25
@julieg18 julieg18 enabled auto-merge (squash) May 31, 2023 13:33
@codeclimate
Copy link

codeclimate bot commented May 31, 2023

Code Climate has analyzed commit 7bde222 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.2% (0.0% change).

View more on Code Climate.

@julieg18 julieg18 merged commit 4ab0a46 into main May 31, 2023
@julieg18 julieg18 deleted the update-setup-install-button branch May 31, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants