Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capabilities to text mentioning storage provider extensions #4015

Merged
merged 3 commits into from
May 31, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented May 31, 2023

Follow up from #4004 (comment). Had to do some research to understand the actual benefit of each extension.

Demo

Screen.Recording.2023-05-31.at.3.45.30.pm.mov

Hot tip: Google Cloud Code is not very helpful

@mattseddon mattseddon added the product PR that affects product label May 31, 2023
@mattseddon mattseddon self-assigned this May 31, 2023
@mattseddon mattseddon marked this pull request as ready for review May 31, 2023 05:49
@mattseddon mattseddon requested review from sroy3 and julieg18 as code owners May 31, 2023 05:49
@mattseddon mattseddon requested a review from shcheklein May 31, 2023 05:53
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks more clear, thanks!

@mattseddon mattseddon enabled auto-merge (squash) May 31, 2023 20:07
@codeclimate
Copy link

codeclimate bot commented May 31, 2023

Code Climate has analyzed commit 90e2488 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.2%.

View more on Code Climate.

@mattseddon mattseddon merged commit 7df876c into main May 31, 2023
@mattseddon mattseddon deleted the update-extension-text branch May 31, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants