Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have setup run different install commands depending on python environment #4048

Closed
wants to merge 1 commit into from
Closed

Have setup run different install commands depending on python environment #4048

wants to merge 1 commit into from

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Jun 6, 2023

  • has setup run a different install command depending on the data given to us by the Python Extension API and defaults to pip if environment type is unknown

Demo

Note: Cut the installation progress to make the demo shorter

conda-installation.mov

Part of #3935

@julieg18 julieg18 added the product PR that affects product label Jun 6, 2023
@julieg18 julieg18 self-assigned this Jun 6, 2023
@julieg18
Copy link
Contributor Author

julieg18 commented Jun 6, 2023

Going to close this for now since it looks like we can use pip to install for most cases. Will reuse some of the logic here for improving the setup though!

@julieg18 julieg18 closed this Jun 6, 2023
@mattseddon mattseddon deleted the improve-install-logic branch August 1, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattseddon mattseddon Awaiting requested review from mattseddon mattseddon will be requested when the pull request is marked ready for review mattseddon is a code owner

@shcheklein shcheklein Awaiting requested review from shcheklein shcheklein will be requested when the pull request is marked ready for review shcheklein is a code owner

Assignees

@julieg18 julieg18

Labels
product PR that affects product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@julieg18