Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plot smooth control background color #4202

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

julieg18
Copy link
Contributor

Tries out comment in #3223:

On some high contrast light / dark themes it blends with the background behind the plots. Should be the color of the plot canvas instead.

We can go ahead and close this if we prefer main :)

main

image image

PR

image image

@julieg18 julieg18 self-assigned this Jun 30, 2023
@julieg18 julieg18 added the product PR that affects product label Jun 30, 2023
@julieg18 julieg18 marked this pull request as ready for review June 30, 2023 22:11
@julieg18 julieg18 requested a review from shcheklein June 30, 2023 22:12
@mattseddon
Copy link
Member

Did you check the zoomed in plot?

@julieg18
Copy link
Contributor Author

Did you check the zoomed in plot?

Yes!

image

@julieg18 julieg18 enabled auto-merge (squash) July 3, 2023 13:12
@codeclimate
Copy link

codeclimate bot commented Jul 3, 2023

Code Climate has analyzed commit 5eb713e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.2% (0.0% change).

View more on Code Climate.

@julieg18 julieg18 merged commit a60e52c into main Jul 3, 2023
3 checks passed
@julieg18 julieg18 deleted the update-plot-smooth-control-color branch July 3, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants