Add dvc.yaml into files used to show editor/title icons #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Jul 6, 2023
| window.showTextDocument(Uri.file(join(dvcDemoPath, fileName))) | ||
|
|
||
| before(async () => { | ||
| await openFileInEditor('dvc.lock') // clear any existing recommendation |
There was a problem hiding this comment.
[F] Because we opened a dvc.yaml in another integration test this started failing. That is just bad testing practices. This change keeps things independent.
|
Code Climate has analyzed commit 01629d0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 92.3% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (-0.1% change). View more on Code Climate. |
|
Unrelated question - is the preview (like for the MD file) a built-in feature? Can we drop the dag there "quickly"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4222
This PR shows the editor/title run/queue experiment icons/actions when a
dvc.yamlis open. This extends the previous behaviour of only showing the icons when a params file is open. I have done this as this will be one of the pathways to execute a particular pipeline (have it open in the active editor).Demo
Screen.Recording.2023-07-06.at.7.24.47.pm.mov