Add select column options to table header cell context menu #4295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
approved these changes
Jul 18, 2023
mattseddon
force-pushed
the
add-context-menu-options
branch
from
196ce87 to
6e0af80
Compare
|
Code Climate has analyzed commit 6e0af80 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 85.7% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<- #4294 <- thisThis PR adds the "Select Columns" and "Select First Columns" commands into the experiment table header cell context menus.
Demo
Screen.Recording.2023-07-18.at.4.19.04.pm.mov
Note: recording that demo made me think that we should either - exclude unselected columns from display first or enable + show them first if they are selected. I am leaning towards the first option (demo in #4296)