Refactor experiment table branch data #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Jul 27, 2023
| export const collectBranchWithRows = ( | ||
| rows: Row<Experiment>[] | ||
| ): [string | typeof WORKSPACE_BRANCH, Row<Experiment>[]][] => { | ||
| const branchesWithRows: [ |
There was a problem hiding this comment.
[F] Usually I would have just used an object here but you can't key an object using undefined | null so I opted for this slightly wacky collection pattern.
mattseddon
commented
Jul 27, 2023
| @@ -52,11 +49,9 @@ export const TableContent: React.FC<TableContentProps> = ({ | |||
|
|
|||
| return ( | |||
| <> | |||
| {branches.map(branch => { | |||
| const branchRows = rows.filter(row => row.original.branch === branch) | |||
There was a problem hiding this comment.
[F] probably just because the focus is on efficiency this week but I decided that we should get this collection done in a single loop.
mattseddon
force-pushed
the
filter-commits
branch
from
2ce43e0 to
49c7273
Compare
mattseddon
force-pushed
the
refactor-branch-data
branch
2 times, most recently
from
8edcf15 to
0b5b22a
Compare
julieg18
approved these changes
Jul 27, 2023
mattseddon
force-pushed
the
refactor-branch-data
branch
from
0b5b22a to
4d4e189
Compare
mattseddon
force-pushed
the
refactor-branch-data
branch
from
4d4e189 to
571d924
Compare
|
Code Climate has analyzed commit 571d924 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 92.3% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<- #4363 <- thisThis PR refactors the way that branch data is passed from the extension to the experiments webview. The main reason for the change is because of a bug surfaced when demoing the previous PR in that filtered branches would not show up as selected under the old logic.
Turns out the mapping of rows back to branches in the experiments webview was a little bit brittle. I have broken it on a few occasions and struggled to get it back working. The idea is to stabilise the logic by keeping it contained in a couple of places and slightly improve efficiency.
Demo (bug from previous PR)
Screen.Recording.2023-07-27.at.5.29.18.pm.mov