Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use insiders for e2e tests (chromium missing) #4669

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Conversation

mattseddon
Copy link
Member

No description provided.

Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pr is still a draft but approving anyway so you are able to merge it when I'm not online :)

demo Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this demo update should be here.

@mattseddon mattseddon marked this pull request as ready for review September 16, 2023 00:59
@mattseddon mattseddon requested a review from sroy3 as a code owner September 16, 2023 00:59
@codeclimate
Copy link

codeclimate bot commented Sep 16, 2023

Code Climate has analyzed commit c2f3524 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.0% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit ba88bef into main Sep 16, 2023
3 checks passed
@mattseddon mattseddon deleted the use-insiders branch September 16, 2023 01:13
@mattseddon mattseddon changed the title Use insiders for e2e tests (chromium) missing Use insiders for e2e tests (chromium missing) Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants