Simplify data structure used to collect multisource encoding update #4687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
simplify-data-structure
branch
from
826e9ee to
ad0b107
Compare
mattseddon
commented
Sep 19, 2023
| ): void => { | ||
| acc[path] = { | ||
| ...acc[path], | ||
| shape: collectEncodingFromValues(Shape, values, lessValuesThanVariations) | ||
| } | ||
| } | ||
|
|
||
| // this is how we can collect the encoding for multi-source plots |
There was a problem hiding this comment.
[F] This was not meant to be committed.
julieg18
approved these changes
Sep 19, 2023
mattseddon
force-pushed
the
simplify-data-structure
branch
from
ad0b107 to
1e86f0f
Compare
|
Code Climate has analyzed commit 7e66973 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that we were collecting data in a more complicated format than is needed/expected whilst working through the logic needed for iterative/dvc-render#142