Add remove as inline SCM action for added resources #4768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
fix-dvc-remove
branch
from
5456413 to
6138e71
Compare
Merged
sroy3
approved these changes
Oct 5, 2023
mattseddon
force-pushed
the
fix-dvc-remove
branch
from
6138e71 to
a3f98ea
Compare
|
Code Climate has analyzed commit a3f98ea and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<- #4769 <- thisBased on feedback provided in a customer call.
We did already have the move command wired up in the
DVC Trackedtree but it not only removed the file/folder but deleted it as well.I have removed the part of the action that deleted the file after removing it from DVC and added the action inline to the SCM tree for "added" resources.
Demo
Screen.Recording.2023-10-05.at.8.06.11.am.mov
Screen.Recording.2023-10-05.at.8.10.17.am.mov
cc @dberenbaum