Add Multiple X Field Selection to Plot Wizard #4797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* simplify plot object * simplify resourcePicker
* fix typo * use same keys message for multi and single files
julieg18
commented
Oct 10, 2023
julieg18
commented
Oct 11, 2023
julieg18
commented
Oct 11, 2023
| it('should return early if the user does not pick a y field', async () => { | ||
| mockedPickFiles.mockResolvedValue(['/file.json']) | ||
| mockedLoadDataFiles.mockResolvedValue([ | ||
| { data: mockValidData, file: 'file.json' } | ||
| ]) | ||
| mockedQuickPickOne.mockResolvedValue('simple') | ||
| mockedGetInput.mockResolvedValue('simple_plot') | ||
| mockedQuickPickValue.mockResolvedValue('actual') | ||
| mockedQuickPickValues | ||
| mockedQuickPickUserOrderedValues | ||
| .mockResolvedValueOnce(undefined) | ||
| .mockResolvedValueOnce([]) |
There was a problem hiding this comment.
This test is actually incorrectly written. We need mockedQuickPickValues to have 4 mockResolvedValueOnce calls. Fixed in #4798
mattseddon
reviewed
Oct 11, 2023
mattseddon
approved these changes
Oct 12, 2023
sroy3
approved these changes
Oct 12, 2023
|
Code Climate has analyzed commit 402d6a2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/3
main<- #4787 <- this <- #4798Demo
Screen.Recording.2023-10-10.at.2.04.36.PM.mov
Part of #4654