Add progress indicator when fetching a studio token #5000
Conversation
julieg18
changed the title
| const token = await this.fetchStudioToken(deviceCode, tokenUri) | ||
| const cwd = this.getCwd() | ||
| private requestStudioToken(deviceCode: string, tokenUri: string) { | ||
| return Toast.showProgress('Connecting to Studio', async progress => { |
There was a problem hiding this comment.
Originally, I was going to update our Studio section with a loading message but, after a 1v1 with Stephanie, decided on using a progress Toast instead since:
- The process is practically near instant for someone with a fast computer, it was just looking really slow from my end since my computer is on the slower side.
- A Toast is less code to do compared to needing to send a message back and forth to the webview.
| @@ -631,7 +631,7 @@ describe('App', () => { | |||
| }) | |||
|
|
|||
| describe('Studio not connected', () => { | |||
| it('should show buttons which request a token from Studio or add an already creatd one', () => { | |||
| it('should show buttons which request a token from Studio or add an already created one', () => { | |||
There was a problem hiding this comment.
Spotted a typo that I went ahead and fixed.
There was a problem hiding this comment.
| @@ -7,7 +7,7 @@ import { Button } from '../../../shared/components/button/Button' | |||
| export const Connect: React.FC = () => { | |||
| return ( | |||
| <EmptyState isFullScreen={false}> | |||
| <div data-testid="setup-studio-content"> | |||
There was a problem hiding this comment.
Pretty unrelated to this pr since I'm no longer updating this section, but we're not using the test id anywhere.
|
Code Climate has analyzed commit 2b87439 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.0% change). View more on Code Climate. |
Demo
Screen.Recording.2023-11-17.at.7.33.12.AM.mov
Part of #3864