Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect columns from experiments under baseline with error #5041

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Nov 29, 2023

Closes #5036

The issue was caused by excluding experiments under baselines without data from column collection. I've added a regression test with the data provided in the issue.

Screenshot

image

@mattseddon mattseddon added the bug Something isn't working label Nov 29, 2023
@mattseddon mattseddon self-assigned this Nov 29, 2023
@mattseddon mattseddon marked this pull request as ready for review November 29, 2023 09:46
@mattseddon mattseddon force-pushed the get-columns-from-broken branch from 9c0cf67 to 602305d Compare November 29, 2023 18:34
@mattseddon mattseddon enabled auto-merge (squash) November 29, 2023 18:34
Copy link

codeclimate bot commented Nov 29, 2023

Code Climate has analyzed commit 602305d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.2% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 37e8668 into main Nov 29, 2023
8 checks passed
@mattseddon mattseddon deleted the get-columns-from-broken branch November 29, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experiments are not shown when baseline commit has an error
3 participants