Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle project having experiments with no data #5045

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Nov 29, 2023

Fixes:

When I'm trying to show experiments/plots, that "You project contains no data".
But I have some... experiments and those plots
Any ideas why is VSCode behave like this?  Also, no clear what should I do here

From https://iterativeai.slack.com/archives/CB41NAL8H/p1701257451702629

@mattseddon mattseddon added the bug Something isn't working label Nov 29, 2023
@mattseddon mattseddon self-assigned this Nov 29, 2023
@mattseddon mattseddon force-pushed the account-for-no-columns branch 2 times, most recently from 0c7a78a to 30925cb Compare November 30, 2023 00:31
@mattseddon mattseddon marked this pull request as ready for review November 30, 2023 00:31
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updates the experiments tree but the webview is still showing the "has no data" message:

Screenshot 2023-11-30 at 8 19 43 AM

I updated Experiments.getHasData(), fixing setup experiments, to see if the webviews could work without none default columns but no luck:

Screenshot 2023-11-30 at 8 18 24 AM

@mattseddon
Copy link
Member Author

This updates the experiments tree but the webview is still showing the "has no data" message:

@julieg18 what data/setup are you using?

@julieg18
Copy link
Contributor

julieg18 commented Nov 30, 2023

@julieg18 what data/setup are you using?

Technically already answered synchronously, but I'm running the project posted by Mikhail in the Slack thread.

@mattseddon mattseddon force-pushed the account-for-no-columns branch from 30925cb to 61d2363 Compare November 30, 2023 22:53
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single plots project is working now, great work!

Copy link

codeclimate bot commented Dec 1, 2023

Code Climate has analyzed commit 215c4b7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.

@julieg18 julieg18 merged commit e7dcdc6 into main Dec 1, 2023
8 checks passed
@julieg18 julieg18 deleted the account-for-no-columns branch December 1, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants