Improve Studio Token Authentication URI Handler #5049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
commented
Nov 30, 2023
| window.registerUriHandler({ | ||
| handleUri(uri: Uri): ProviderResult<void> { | ||
| if (uri.path.startsWith(path)) { | ||
| if (uri.path === path) { |
There was a problem hiding this comment.
Studio is now decoding the query redirect_uri before redirecting so we can use the equals check.
| void waitForUriResponse('/studio-complete-auth', () => { | ||
| void this.requestStudioToken(deviceCode, tokenUri) | ||
| }) | ||
| this.studioAccessTokenUriHandler = waitForUriResponse( |
There was a problem hiding this comment.
Realized we aren't disposing the uri handler after use. I updated the code to dispose of the listener if:
- we get a response from Studio
- the user wants to try authentication from the start again
mattseddon
reviewed
Dec 1, 2023
mattseddon
approved these changes
Dec 1, 2023
sroy3
approved these changes
Dec 1, 2023
|
Code Climate has analyzed commit 8a403a8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are inline.
Related to #3864