Handle missing items in drag and drop container #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Nov 30, 2023
| </tbody> | ||
| ) | ||
| }) | ||
| .filter(Boolean) as JSX.Element[] |
There was a problem hiding this comment.
[F] The filter is the only change.
mattseddon
commented
Nov 30, 2023
| @@ -297,6 +297,9 @@ export const DragDropContainer: React.FC<DragDropContainerProps> = ({ | |||
|
|
|||
| const wrappedItems = items | |||
| .map(draggable => { | |||
| if (!draggable) { | |||
There was a problem hiding this comment.
[F] This is another just in case (the resulting array was already filtered).
mattseddon
force-pushed
the
fix-undefined-item
branch
from
ac060c7 to
bb0132c
Compare
|
Code Climate has analyzed commit bb0132c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 87.5% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
mattseddon
commented
Dec 1, 2023
| </tbody> | ||
| ) | ||
| }) | ||
| const rows = rowsOrder |
There was a problem hiding this comment.
[F] rowsOrder can contain paths that no longer exist because it is updated by setRowsOrder from useState.
julieg18
approved these changes
Dec 1, 2023
sroy3
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5052