Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use signal API to simplify using the smooth slider #5077

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented Dec 6, 2023

Recreated #5066

The bug (mutation of props when zooming) was solved by the standardisation of plots, but there were other changes in the PR that also helps simplifying the code, so I brought back the changes and fixed #5066 (comment)

Demo

Screen.Recording.2023-11-28.at.2.51.51.PM.mov

@sroy3 sroy3 self-assigned this Dec 6, 2023
@sroy3 sroy3 marked this pull request as ready for review December 6, 2023 15:59
Copy link

codeclimate bot commented Dec 6, 2023

Code Climate has analyzed commit 71b9d08 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.2% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattseddon mattseddon merged commit 241e2d2 into main Dec 7, 2023
8 checks passed
@mattseddon mattseddon deleted the smooth-signal branch December 7, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants