Add self-hosted url info in Studio setup section #5089
Conversation
| @@ -22,9 +27,28 @@ export const Studio: React.FC<{ | |||
| ) | |||
| } | |||
|
|
|||
| const children = selfHostedStudioUrl && ( | |||
| <DetailsTable> | |||
There was a problem hiding this comment.
Currently, we only see this table if the user has a self-hosted URL. But we could also adjust the table to show URL information always. This might help prem users who haven't updated as well. Example:
| @@ -22,9 +27,28 @@ export const Studio: React.FC<{ | |||
| ) | |||
| } | |||
|
|
|||
| const children = selfHostedStudioUrl && ( | |||
There was a problem hiding this comment.
[I] We should always show this part of the section so that users know the option is available.
When there is no URL set we can present "None" (or match what we show elsewhere on the setup page) in place of the URL.
There was a problem hiding this comment.
Good point! I'll update the section.
| }) | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| stub(Setup.prototype as any, 'getCliCompatible').returns(true) |
There was a problem hiding this comment.
[C] Maybe this should be moved into buildSetup
There was a problem hiding this comment.
and should be stubbed on the instance (if possible)
There was a problem hiding this comment.
I was thinking about that as well since we are running this line in multiple tests. I'll look into moving it in a followup.
| text: 'Remove' | ||
| } | ||
| ] | ||
| : [{ onClick: saveStudioUrl, text: 'Add Url' }] |
There was a problem hiding this comment.
[Q] Should this be "Add"? Does the text appear too short?
There was a problem hiding this comment.
[Q] Should this be "Add"? Does the text appear too short?
Yes, the text appeared too short :)
|
Code Climate has analyzed commit c14c1b2 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 97.7% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.0% change). View more on Code Climate. |
Demo
https://github.com/iterative/vscode-dvc/assets/43496356/0c9cfbb5-c820-4760-acf2-fdb3f80541c5Screen.Recording.2023-12-12.at.8.31.30.AM.mov
Fixes #5035