Add lint rule for one React component per file #5113
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| size: DEFAULT_COLUMN_WIDTH | ||
| } | ||
|
|
||
| export const ExperimentsTable: React.FC = () => { |
There was a problem hiding this comment.
Function ExperimentsTable has 67 lines of code (exceeds 40 allowed). Consider refactoring.
| import { Modal } from '../../shared/components/modal/Modal' | ||
| import { PlotsState } from '../store' | ||
|
|
||
| export const PlotsContent = () => { |
There was a problem hiding this comment.
Function PlotsContent has 72 lines of code (exceeds 40 allowed). Consider refactoring.
|
|
||
| export const PlotsContent = () => { | ||
| const dispatch = useDispatch() | ||
| const { hasData, hasPlots, hasUnselectedPlots, zoomedInPlot, cliError } = |
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
| import React, { PropsWithChildren } from 'react' | ||
| import styles from './styles.module.scss' | ||
|
|
||
| export const PathHighlight: React.FC<PropsWithChildren> = ({ children }) => ( |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
|
||
| export const PlotsContent = () => { | ||
| const dispatch = useDispatch() | ||
| const { hasData, hasPlots, hasUnselectedPlots, zoomedInPlot, cliError } = |
There was a problem hiding this comment.
Similar blocks of code found in 5 locations. Consider refactoring.
|
Code Climate has analyzed commit d1122ac and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 99.1% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2%. View more on Code Climate. |
We have mentioned this before, but seems like it keeps happening.