Upgrade Storybook to v7.6 #5115
Conversation
| @@ -1,6 +1,5 @@ | |||
| import { Preview } from '@storybook/react' | |||
| import { InternalVsCodeApi } from '../src/shared/api' | |||
| import { action } from '@storybook/addon-actions' | |||
There was a problem hiding this comment.
[F] This is the source of the bug. Having action wrapped around postMessage/setState in the VS Code API meant that we could record the payload sent to the extension. I have not used this in a long time and I think we should be testing that functionality differently (i.e. automated tests). I have removed it so that we can move forwards but we can park this for a while if you feel differently.
There was a problem hiding this comment.
(@storybook/addon-actions tries to import @storybook/globals which is no longer available)
| @@ -10,8 +10,6 @@ export const config: StorybookConfig = { | |||
| staticDirs: ['../../extension/src/test/fixtures/plotsDiff/staticImages'], | |||
| addons: [ | |||
| 'storybook-addon-themes', | |||
| '@storybook/addon-essentials', | |||
| '@storybook/addon-interactions', | |||
There was a problem hiding this comment.
[F] Unless chromatic uses this I don't think we actually use it at all.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
mattseddon
force-pushed
the
update-storybook
branch
from
5f17de9 to
7c88b37
Compare
|
Code Climate has analyzed commit a326f9b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.0% change). View more on Code Climate. |
Comments inline