Remove Studio data request failed Toast #5125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
commented
Dec 15, 2023
| @@ -157,9 +156,6 @@ export class ExperimentsData extends BaseData<ExperimentsOutput> { | |||
| }) | |||
| } catch { | |||
| this.notifyChanged(defaultData) | |||
| void Toast.showError( | |||
There was a problem hiding this comment.
We could add some logic to check if the user has already received the Toast and has a self-hosted URL, but that would add some extra complexity that I don't think is needed since we probably have few users using self-hosted URLs.
There was a problem hiding this comment.
We can have a health status in the Setup screen instead I think. If connection is failing we can a message, or even change it to "yellow" in the Setup screen. WDYT?
sroy3
approved these changes
Dec 15, 2023
|
Code Climate has analyzed commit a867b3e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the "Unable to fetch data from Studio" Toast since we try to fetch data periodically (meaning user could get this multiple times in a session)
Fixes #5120