Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all experiments to runs view #673

Merged
merged 6 commits into from
Jul 23, 2021
Merged

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Jul 23, 2021

This PR adds all of the existing experiment names to the experiments runs view.

Screenshot:

image

Closes #658.

There are a couple of things to be noted from working on this ticket.

  1. I am unable to display multiple icons for the experiment records. That means that a coloured dot AND open / closed eyes looks unlikely. Perhaps we can have a coloured open / closed eye?
  2. As a result of the first issue I have not started to address different colours within the view.

I've raised another checkbox in #175 (comment) to discuss.

@mattseddon mattseddon added the product PR that affects product label Jul 23, 2021
@mattseddon mattseddon self-assigned this Jul 23, 2021
@mattseddon mattseddon mentioned this pull request Jul 23, 2021
13 tasks
@mattseddon mattseddon marked this pull request as ready for review July 23, 2021 05:40
@codeclimate
Copy link

codeclimate bot commented Jul 23, 2021

Code Climate has analyzed commit f089e70 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 95.6% (85% is the threshold).

This pull request will bring the total coverage in the repository to 93.8% (0.0% change).

View more on Code Climate.

@rogermparent rogermparent merged commit 91a04e3 into master Jul 23, 2021
@rogermparent rogermparent deleted the add-all-experiments-to-runs branch July 23, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show all experiments as specified by the recent plots spec in the RUNS panel
2 participants