-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic client #14
Add basic client #14
Conversation
Remove dummy data script - this will be located in a separate repository
Add static type pytest
Add github actions workflow to test client for different python versions
Deploying with Cloudflare Pages
|
7c2330b
to
290c9bd
Compare
Debug CI
290c9bd
to
7fb87a0
Compare
Start implementing client class
Add example script
Add option to block during message sending
Add more comments to example script
Refactor publish API, add measurement publishing
Add acknowledgement publishing
Make message timestamps configurable
Receive configurations
Ping me when it's ready for review 😉 |
Add script to start an MQTT broker in a docker container This broker has password authentication which cannot be tested with the `test.mosquitto.org` broker
Implement readable error messages on connection failure
Test various connection failures/success
Add `on_config_message` and `on_publish` callbacks Add more comments Refactor client class
Use `connection_timeout` argument to make tests fail faster
Extend example code with callbacks
Write script that converts example code into markdown file
Update example code and conversion script
Use public MQTT broker, debug static types
Add TLS support
Test TLS support in connection tests
Remove unused local mosquitto docker broker
Add TLS to example Improve TLS args docs Rename `revision` parameter to `config_revision` Order pytests (static type tests first)
Add documentation generation
Update documentation Write test that checks whether documentation is up to date
Add test for config receiving
Add mosquitto dependencies to CI workflow
Add publishing test to improve coverage
Convert instance variables to class variables in order to sync the state between threads Update TLS Protocol in Example
Possibly debug race conditions during publishing
Hi, @empicano! I think it is ready for review :) Some comments:
I am looking forward to your comments! EDIT: I just noticed that only the |
Update docstrings and remove `TentaClient.reset` method
Fix returns in docstrings Add comment about long connection time on wrong ports Add `py.typed` file
Fix typos in client and example code
Restructure `ConfigMessage` and `TLSParameters` class so that they are rendered in the API reference as well
It closed the PR, when I renamed the branch, sorry ^^ I will open a new one at #21 |
Moved to #21