Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PubKeySecurityHandler output stream with DER encoding format #81

Closed

Conversation

realityone
Copy link
Contributor

Hi there,

I found an incompatible behavior in PubKeySecurityHandler.

We upgrade bouncycastle in 7.1.14, and change the DEROutputStream to ASN1OutputStream, but as the documentation described, the encoding should be specified as ASN1Encoding.DER.

Without this encoding parameter the PDF cannot be opened by Adobe Acrobat.

Here is the pdf generated by test case.

Thanks for reviewing.

@Snipx
Copy link
Contributor

Snipx commented Nov 24, 2021

Hi @realityone and thank you for your Pull Request!
Would you mind signing the Contributor License Agreement and send back to us? The details are available at https://itextpdf.com/en/how-buy/legal/itext-contributor-license-agreement

@realityone
Copy link
Contributor Author

Hi @realityone and thank you for your Pull Request!
Would you mind signing the Contributor License Agreement and send back to us? The details are available at https://itextpdf.com/en/how-buy/legal/itext-contributor-license-agreement

Hi, I have sent the signed iCLA to dev.intern@itextpdf.com.

@yulian-gaponenko
Copy link
Member

Hi @realityone

PR was merged to develop: 6919b5c

This fix is quite important and impactful, thanks again for you contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants