Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ERC20 as gas fee #15

Merged
merged 5 commits into from
Oct 31, 2024
Merged

feat: add ERC20 as gas fee #15

merged 5 commits into from
Oct 31, 2024

Conversation

qizhou
Copy link
Contributor

@qizhou qizhou commented Oct 17, 2024

Add a tutorial to demonstrate an EIP-7702 scenario, where the user can sign an off-chain authorization to send an ERC20 token while paying the gas sponsor ERC20 token. Note that this feature can be achieved by combining the SimpleDelegateContract.sol with an authorization check (like in P256Delegation.sol), but this tutorial aims to provide a clearer example on how ERC20 as gas fee is achieved step by step.

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool,
I think we want this @klkvr ?

should we also list this here: https://github.com/ithacaxyz/odyssey-examples?tab=readme-ov-file#chapter-1

@mattsse mattsse requested a review from klkvr October 18, 2024 20:10
Copy link
Member

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! yep, I think we want to include this though I think we can demonstrate a more powerful usecase

chapter1/contracts/src/ERC20Fee.sol Outdated Show resolved Hide resolved
@qizhou
Copy link
Contributor Author

qizhou commented Oct 19, 2024

cool, I think we want this @klkvr ?

should we also list this here: https://github.com/ithacaxyz/odyssey-examples?tab=readme-ov-file#chapter-1

The description is also added. Please take a loot.

@Rjected Rjected changed the title add ERC20 as gass fee add ERC20 as gas fee Oct 22, 2024
@Rjected Rjected changed the title add ERC20 as gas fee feat: add ERC20 as gas fee Oct 22, 2024
@klkvr klkvr merged commit b7d1494 into ithacaxyz:main Oct 31, 2024
@klkvr klkvr mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants