Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : remove duplicate secp256r1 #76

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Conversation

mahmudsudo
Copy link
Contributor

closes #42

crates/precompile/Cargo.toml Outdated Show resolved Hide resolved
crates/precompile/src/secp256r1.rs Outdated Show resolved Hide resolved
crates/precompile/Cargo.toml Outdated Show resolved Hide resolved
crates/precompile/Cargo.toml Outdated Show resolved Hide resolved
crates/node/src/evm.rs Outdated Show resolved Hide resolved
crates/node/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mahmudsudo
Copy link
Contributor Author

@mattsse
@onbjerg
@Rjected

@mahmudsudo
Copy link
Contributor Author

.github/workflows/dependencies.yml:55:15: the runner of "peter-evans/create-pull-request@v5" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
|
55 | uses: peter-evans/create-pull-request@v5
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: Process completed with exit code 1.

@mattsse

mattsse pushed a commit that referenced this pull request Nov 6, 2024
Updates the `create-pull-request` action from v5 to v7. This should fix
the issues here:
#76 (comment)
@mattsse mattsse merged commit 820c180 into ithacaxyz:main Nov 6, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated secp256r1 precompiles code
3 participants