Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Refactor Network Subcommands #108

Merged
merged 4 commits into from
Oct 24, 2024
Merged

chore: Refactor Network Subcommands #108

merged 4 commits into from
Oct 24, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Oct 24, 2024

Description

Refactors the network subcommands to make them more explicit.

Now there is just

Discovery subcommand

hera disc

Gossip subcommand

hera gossip

@refcell refcell self-assigned this Oct 24, 2024
merklefruit
merklefruit reviewed Oct 24, 2024
View reviewed changes
bin/hera/src/gossip.rs Outdated Show resolved Hide resolved
refcell and others added 2 commits October 24, 2024 10:33
@refcell
chore: cleanup logging
fd99d0b
@refcell @merklefruit
Update bin/hera/src/gossip.rs
105b36b 
Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com>
@refcell refcell marked this pull request as ready for review October 24, 2024 14:34
merklefruit
merklefruit approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@refcell refcell merged commit 5aec5a5 into main Oct 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merklefruit merklefruit merklefruit approved these changes

Assignees

@refcell refcell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @merklefruit