Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): Setup RPC Crate #35

Merged
merged 4 commits into from
Oct 17, 2024
Merged

feat(rpc): Setup RPC Crate #35

merged 4 commits into from
Oct 17, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Aug 26, 2024 •
edited
Loading

Description

Sets up an rpc crate.

Metadata

#7

@refcell refcell marked this pull request as draft August 26, 2024 11:54
@refcell refcell self-assigned this Aug 26, 2024
@refcell refcell added the A-rpc Area: rpc crate label Aug 26, 2024
@refcell refcell marked this pull request as ready for review August 26, 2024 21:29
@refcell
Copy link
Collaborator Author

refcell commented Aug 26, 2024

Going to cut this off here with unimplemented for others to impl - I'm not as familiar with how this could work well with reth. Would appreciate any guidance if you have bandwidth @Rjected

@refcell refcell marked this pull request as draft August 26, 2024 23:12
Rjected
Rjected reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping these unimplemented for now makes sense in terms of crate setup, added some comments on how you might implement the full thing

crates/rpc/src/rollup.rs Show resolved Hide resolved
@merklefruit merklefruit mentioned this pull request Aug 27, 2024
Open
@merklefruit merklefruit mentioned this pull request Sep 22, 2024
Closed
@refcell refcell marked this pull request as ready for review October 17, 2024 20:08
mattsse
mattsse reviewed Oct 17, 2024
View reviewed changes
crates/rpc/Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@refcell refcell merged commit a809286 into main Oct 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merklefruit merklefruit merklefruit left review comments

@mattsse mattsse mattsse left review comments

@Rjected Rjected Rjected left review comments

Assignees

@refcell refcell

Labels
A-rpc Area: rpc crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@refcell @Rjected @mattsse @merklefruit