Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hera): Subcommands #63

Merged
merged 6 commits into from
Aug 31, 2024
Merged

feat(hera): Subcommands #63

merged 6 commits into from
Aug 31, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Aug 29, 2024

Description

Warning

Blocked by #62.

Splits the hera command into network and node subcommands to clean up the binary entrypoints.

@refcell refcell added the A-hera Area: OP Stack Rollup node binary label Aug 29, 2024
@refcell refcell self-assigned this Aug 29, 2024
@refcell refcell added C-enhancement New feature or request D-do-not-merge Desc: Do not merge labels Aug 29, 2024
@refcell refcell mentioned this pull request Aug 30, 2024
Merged
@refcell refcell added the D-stacked Desc: Stacked ontop of another PR label Aug 30, 2024
merklefruit
merklefruit requested changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like this!! A few nits

bin/hera/src/network.rs Outdated Show resolved Hide resolved
bin/hera/src/main.rs Outdated Show resolved Hide resolved
bin/hera/src/network.rs Outdated Show resolved Hide resolved
@refcell refcell merged commit 0bbb8e4 into main Aug 31, 2024
11 checks passed
@refcell refcell deleted the rf/feat/split-hera-command branch August 31, 2024 23:40
refcell added a commit that referenced this pull request Aug 31, 2024
@refcell
fix(net): Retry discv5 Service on Startup (#64)
b4ab150 
### Description

> [!WARNING]
>
> Blocked by #63.

Retries discv5 service on startup with error logging for easy debugging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merklefruit merklefruit Awaiting requested review from merklefruit

Assignees

@refcell refcell

Labels
A-hera Area: OP Stack Rollup node binary C-enhancement New feature or request D-do-not-merge Desc: Do not merge D-stacked Desc: Stacked ontop of another PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @merklefruit