fix(storybook): add useDefineForClassFields false #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of TypeScript 4.3.1+, [one must specify `useDefineForClassFields: false` explicitly](evanw/esbuild#1354 (comment)) when targeting ESNext, because [TC39 now uses the same syntax](https://www.typescriptlang.org/tsconfig#useDefineForClassFields) and these would conflict otherwise. Updating this configuration allows the Storybook configuration to continue working. Pharos itself never broke because it is currently targeting `es2019`. Chromatic didn't catch this because it targets `firefox65` because Chromatic has a really crusty old Firefox. Womp.
daneah
requested review from
SMQuazi and
maddy531
and removed request for
a team
|
satya-achanta-venkata
approved these changes
Dec 28, 2021
size-limit report 📦
|
|
I wonder: Should we pre-emptively add |
Niznikr
approved these changes
Dec 29, 2021
sirrah-tam
pushed a commit
to sirrah-tam/pharos
that referenced
this pull request
Dec 1, 2023
* fix(storybook): add useDefineForClassFields false As of TypeScript 4.3.1+, [one must specify `useDefineForClassFields: false` explicitly](evanw/esbuild#1354 (comment)) when targeting ESNext, because [TC39 now uses the same syntax](https://www.typescriptlang.org/tsconfig#useDefineForClassFields) and these would conflict otherwise. Updating this configuration allows the Storybook configuration to continue working. Pharos itself never broke because it is currently targeting `es2019`. Chromatic didn't catch this because it targets `firefox65` because Chromatic has a really crusty old Firefox. Womp. * fix(pharos): add useDefineForClassFields to main package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Resolves #287
As of TypeScript 4.3.1+, one must specify
useDefineForClassFields: falseexplicitly when targeting ESNext, because TC39 now uses the same syntax and these would conflict otherwise.How does this change work?
Updating this configuration allows the Storybook configuration to continue working.
Additional context
Pharos itself never broke because it is currently targeting
es2019. Chromatic didn't catch this because it targetsfirefox65because Chromatic has a really crusty old Firefox. Womp.