Feature/cra to vite #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
reviewed
Jun 7, 2024
Comment on lines
+31
to
+36
| VITE_APP_API_BASE=API_URL_HERE # most probably https://aapodwalk-api.local.itkdev.dk/ | ||
| VITE_APP_API_ROUTE=api/v1/ | ||
| VITE_APP_TOKEN=token_stuff_here # created in api (123?) | ||
|
|
||
| REACT_APP_DF_MAP_USERNAME=username_here # can be found in 1password | ||
| REACT_APP_DF_MAP_PASSWORD=password_here # can likewise be found in 1password | ||
| VITE_APP_DF_MAP_USERNAME=username_here # can be found in 1password | ||
| VITE_APP_DF_MAP_PASSWORD=password_here # can likewise be found in 1password |
There was a problem hiding this comment.
Do we really need the name of something we use to build the project in variable names? Couldn't we just use APP_ as the prefix?
There was a problem hiding this comment.
+ rather than interpolation, improved readability Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
rimi-itk
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it seems CRA is no longer being maintained by fb, I am migrating to Vite.