Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2514: Add button texts for screenreaders #35

Merged
merged 2 commits into from
Oct 11, 2024
Merged

2514: Add button texts for screenreaders #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94478ff
2514: Add button texts for screenreaders
yepzdk Sep 23, 2024
68c76f6
2514: Update changelog
yepzdk Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ See [keep a changelog] for information about writing changes to this log.

## [Unreleased]

- [PR-35](https://github.com/itk-dev/ai-launchpad/pull/35)
Fix accessibility issues discovered with wave tool.

## [1.0.2] - 2024-20-09

- [PR-34](https://github.com/itk-dev/ai-launchpad/pull/34)
Expand Down
2 changes: 1 addition & 1 deletion web/themes/custom/ai_launchpad/templates/chat/chat-btn-close.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<button id="btnCloseChat" class="btn-icon"><i class="icon fa-solid fa-xmark"></i></button>
<button id="btnCloseChat" class="btn-icon"><i class="icon fa-solid fa-xmark"></i><span class="sr-only">{{ 'Close chat'|t }}</span></button>
2 changes: 1 addition & 1 deletion web/themes/custom/ai_launchpad/templates/chat/chat-btn-minimize.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<button id="btnMinimizeChat"class="btn-icon"><span id="minimize"><i class="icon fa-solid fa-window-minimize">{{ 'Minimize'|t }}</i></span><span id="maximize" class="hidden"><i class="icon fa-solid fa-window-maximize">{{ 'Maximize'|t }}</i></span></button>
<button id="btnMinimizeChat"class="btn-icon"><span id="minimize"><i class="icon fa-solid fa-window-minimize"></i><span class="sr-only">{{ 'Minimize'|t }}</span></span><span id="maximize" class="hidden"><i class="icon fa-solid fa-window-maximize"></i><span class="sr-only">{{ 'Maximize'|t }}</span></span></button>
2 changes: 1 addition & 1 deletion web/themes/custom/ai_launchpad/templates/components/global-navigation.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{{ page.header.ai_launchpad_sitebranding }}
</div>
<button class="ms-auto" id="btnCloseGlobalNavigation">
<i class="fa-solid fa-xmark"></i>
<i class="fa-solid fa-xmark"></i><span class="sr-only">{{ 'Close navigation menu'|t }}</span>
</button>
</header>
<main class="text-primary">
Expand Down
2 changes: 1 addition & 1 deletion web/themes/custom/ai_launchpad/templates/components/nav-button.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<div class="nav-button">
<button id="btnOpenGlobalNavigation" class="border border-secondary bg-secondary text-secondary rounded px-3 py-2"><i class="fa-solid fa-bars"></i></button>
<button id="btnOpenGlobalNavigation" class="border border-secondary bg-secondary text-secondary rounded px-3 py-2"><i class="fa-solid fa-bars"></i><span class="sr-only">{{ 'Open navigation menu'|t }}</span></button>
</div>
Loading