1280: Simplified planning form. Added default value #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up UI for planning
rimi-itk
reviewed
May 3, 2024
Comment on lines
27
to
28
| const { x } = scrollToColumn.getBoundingClientRect(); | ||
| const { x: firstColumnX } = firstColumn.getBoundingClientRect(); |
There was a problem hiding this comment.
It took me a while to actually understand what's going on here.
Suggested change
| const { x } = scrollToColumn.getBoundingClientRect(); | |
| const { x: firstColumnX } = firstColumn.getBoundingClientRect(); | |
| const x = scrollToColumn.getBoundingClientRect().x; | |
| const firstColumnX = firstColumn.getBoundingClientRect().x; |
is much easier to understand.
There was a problem hiding this comment.
Changed it. Thanks for the suggestion.
| @@ -378,6 +377,7 @@ public function getPlanningDataWeeks(): PlanningData | |||
| $weeks = $planning->weeks; | |||
|
|
|||
| $currentYear = (int) (new \DateTime())->format('Y'); | |||
| $currentWeek = (int) (new \DateTime())->format('W'); | |||
|
|
|||
| for ($weekNumber = 1; $weekNumber <= 52; ++$weekNumber) { | |||
There was a problem hiding this comment.
A year can actually have 53 weeks (cf. https://en.wikipedia.org/wiki/ISO_week_date#Weeks_per_year), and the year 2026 (in the near future is one of them), so this should be rewritten to iterate over all weeks in the year (or use https://stackoverflow.com/a/21480444).
There was a problem hiding this comment.
I can't take credit for this. So, I have pasted your suggestion into a comment.
rimi-itk
approved these changes
May 3, 2024
rimi-itk
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/1280
Description
Simplified planning form. Added default value.
Checklist