Simplified hour report form #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeppekroghitk
approved these changes
Jun 24, 2024
| 'data-preselect-date' => $this->hourReportService->getToDate(), | ||
| ], | ||
| ]); | ||
| $form->add('submit', ButtonType::class, [ |
There was a problem hiding this comment.
The thought about adding a submit button, is to prevent the report from being loaded before the user is done configuring what they want to see. As the report takes a bit to compute, i imagine that it is going to be annoying potentially waiting for data three times, before the form is fully configured.
As fromDate and toDate is preconfigured, selecting a version will cause the report to be loaded the first time.
If you want to change fromDate, the report is loaded for the second time and after changing toDate, the report is loaded for the third time.
I think we need to solve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/1742
Description
Simplified hour report form.
Checklist