2033: Sync worklogs from invoice entry #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeppekroghitk
changed the base branch from
develop
to
feature/2034-invoice-date-select-continuity
jeppekroghitk
force-pushed
the
feature/2034-invoice-date-select-continuity
branch
from
80ad37b
to
4886af4
Compare
…to call controller
jeppekroghitk
force-pushed
the
feature/2033-sync-worklogs-from-invoice-entry
branch
from
e5f6566
to
8131b98
Compare
tuj
requested changes
Aug 9, 2024
| /** | ||
| * @throws EconomicsException | ||
| */ | ||
| #[Route('/{projectId}/sync', name: 'app_invoice_entry_project_worklogs_sync', methods: ['POST'])] |
There was a problem hiding this comment.
Use route in project controller instead
| </svg> | ||
| `; | ||
|
|
||
| fetch(this.updateUrl, { |
| this.updateUrl = this.element.dataset.updateUrl; | ||
| } | ||
|
|
||
| syncWorklogs(e) { |
There was a problem hiding this comment.
Cleanup implementation so html is in the twig component and this controller just changes state of the html
| let successText = syncButton.dataset.successtext; | ||
| syncButton.disabled = true; | ||
| syncButton.innerHTML = ` | ||
| <svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" strokeWidth="1.5" stroke="currentColor" className="size-6"> |
There was a problem hiding this comment.
use components/icons.html.twig instead
…onent based on its type
…oved isBillable to filter area
…f no filters is yet set
tuj
requested changes
Aug 13, 2024
| @@ -1,6 +1,12 @@ | |||
| <header class="w-full flex justify-between items-center"> | |||
| <h1 class="page-title">{{ title }}</h1> | |||
| {% if link_url|default(false) %} | |||
There was a problem hiding this comment.
This change requires that you change the other parts that use:
components/page-header.html.twig
otherwise, they will not display the link
jeppekroghitk
force-pushed
the
feature/2034-invoice-date-select-continuity
branch
from
cfd3b9c
to
d46cd1e
Compare
jeppekroghitk
force-pushed
the
feature/2034-invoice-date-select-continuity
branch
from
21c1145
to
2a6f11e
Compare
…re/2033-sync-worklogs-from-invoice-entry
tuj
approved these changes
Aug 13, 2024
Base automatically changed from
feature/2034-invoice-date-select-continuity
to
develop
August 14, 2024 07:48
jeppekroghitk
deleted the
feature/2033-sync-worklogs-from-invoice-entry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/?tab=ticketdetails#/tickets/showTicket/2033
Description
When adding worklogs to an invoice entry, a button should be displayed to sync worklogs to the project, ensuring that all worklogs are synced when needed.
Screenshot of the result
Checklist