3298: Report Notification Subscription #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ stimulus controller for subscribe button
…ribing to reports
…e + Reduced migraitons
tuj
requested changes
Oct 1, 2024
| } | ||
| break; | ||
| default: | ||
| return new JsonResponse(['success' => false], 200); |
There was a problem hiding this comment.
I think you should throw an exception here instead.
BadRequestHttpException.
Then you do not have to send success => true in the responses and it makes it clear that something unsupported has been requested
| $subscriptions = $this->subscriptionRepository->findByCustom($userEmail, $content); | ||
| $frequencies = $this->getFrequencies($subscriptions); | ||
|
|
||
| return new JsonResponse(['success' => true, 'action' => 'unsubscribed', 'frequencies' => $frequencies], 200); |
There was a problem hiding this comment.
response code 200 already signifies success.
| {% set number_of_columns = 11 %} | ||
|
|
||
| {{ form_start(form) }} | ||
| <div class="form-default"> |
There was a problem hiding this comment.
This block should be indented 1 tab.
tuj
approved these changes
Oct 1, 2024
jeppekroghitk
deleted the
feature/2398-report-notification-subscription
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
2398
Description
This PR introduces a new Subscription feature that enables users to opt into specific reports on a monthly or quarterly basis. Subscribed users will then receive an email containing the chosen report which covers the specified period for the relevant project.
Screenshot of the result
N/A
Checklist