Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

318 - Easy admin (UI) - MVP version #24

Merged
merged 18 commits into from
Nov 27, 2023
Merged

318 - Easy admin (UI) - MVP version #24

merged 18 commits into from
Nov 27, 2023

Conversation

cableman
Copy link
Contributor

@cableman cableman commented Nov 14, 2023 •
edited
Loading

Link to ticket

https://jira.itkdev.dk/browse/EV-318

Description

  • Install and configure Easy Admin.
  • Updated all composer packages.
  • Added title to events (ohhh yes).
  • Added more fixtures to better build UI.
  • Simple user login for now to easy admin
  • Prepared for translations

Screenshot of the result

N/A

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

N/A

@cableman cableman changed the base branch from develop to feature/268-output-indexing November 20, 2023 15:40
Base automatically changed from feature/268-output-indexing to develop November 21, 2023 12:00
@cableman cableman changed the title Feature/318 easy admin 318 - Easy admin (UI) Nov 21, 2023
@cableman cableman changed the title 318 - Easy admin (UI) 318 - Easy admin (UI) - MVP version Nov 22, 2023
@cableman cableman force-pushed the feature/318-easy-admin branch 2 times, most recently from d81446e to 7762de8 Compare November 22, 2023 15:50
@cableman cableman marked this pull request as ready for review November 22, 2023 16:09
rimi-itk
rimi-itk requested changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@rimi-itk rimi-itk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor changes requested/suggested. Some general remarks:

  • Consider using yield (rather than arrays) in admin CRUD controllers
  • Make static texts translatable

migrations/Version20231121145109.php Show resolved Hide resolved
src/Controller/Admin/AddressCrudController.php Show resolved Hide resolved
src/Controller/Admin/EventCrudController.php Show resolved Hide resolved
src/Controller/Admin/AddressCrudController.php Outdated Show resolved Hide resolved
src/Controller/Admin/AddressCrudController.php Outdated Show resolved Hide resolved
src/DataFixtures/OccurrenceFixture.php Outdated Show resolved Hide resolved
src/Controller/LoginController.php Outdated Show resolved Hide resolved
@cableman cableman merged commit 4c96b8d into develop Nov 27, 2023
7 checks passed
@cableman cableman deleted the feature/318-easy-admin branch November 27, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rimi-itk rimi-itk rimi-itk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cableman @rimi-itk