Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/687 api index updates #40

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Conversation

turegjorup
Copy link
Contributor

Link to ticket

Please add a link to the ticket being addressed by this change.

Description

Please include a short description of the suggested change and the reasoning behind the approach you have chosen.

Screenshot of the result

If your change affects the user interface you should include a screenshot of the result with the pull request.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer please add them here.

@turegjorup turegjorup self-assigned this Apr 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 106 lines in your changes are missing coverage. Please review.

Project coverage is 0.41%. Comparing base (5bf666e) to head (59ef81f).
Report is 8 commits behind head on develop.

Files Patch % Lines
src/Command/Feed/FeedImportCommand.php 0.00% 27 Missing ⚠️
src/Command/Index/IndexPopulateCommand.php 0.00% 19 Missing ⚠️
src/Service/Indexing/AbstractIndexingElastic.php 0.00% 18 Missing ⚠️
src/Service/Feeds/Mapper/Source/FeedItemSource.php 0.00% 10 Missing ⚠️
src/Entity/Tag.php 0.00% 5 Missing ⚠️
src/Entity/Vocabulary.php 0.00% 5 Missing ⚠️
src/EventSubscriber/EasyAdminSubscriber.php 0.00% 4 Missing ⚠️
src/Factory/EventFactory.php 0.00% 4 Missing ⚠️
src/Factory/OrganizationFactory.php 0.00% 3 Missing ⚠️
...rc/Model/Indexing/Mappings/OccurrenceWithEvent.php 0.00% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff              @@
##             develop     #40      +/-   ##
============================================
- Coverage       0.42%   0.41%   -0.02%     
- Complexity       833     857      +24     
============================================
  Files            120     123       +3     
  Lines           3034    3162     +128     
============================================
  Hits              13      13              
- Misses          3021    3149     +128     
Flag Coverage Δ
8.3 0.41% <0.00%> (-0.02%) ⬇️
unittests 0.41% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turegjorup turegjorup merged commit 5f85e2a into develop Apr 29, 2024
7 checks passed
@turegjorup turegjorup deleted the feature/687_api_index_updates branch April 29, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants