Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1284: Added PethPrefix scope to traefik rules to allow co-hosting with legacy eventdb #41

Merged
merged 2 commits into from
May 3, 2024

Conversation

turegjorup
Copy link
Contributor

Link to ticket

https://leantime.itkdev.dk/tickets/showKanban?tab=timesheet#/tickets/showTicket/1284

Description

Added PethPrefix scope to traefik rules to allow co-hosting with legacy eventdb

Screenshot of the result

If your change affects the user interface you should include a screenshot of the result with the pull request.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer please add them here.

@turegjorup turegjorup self-assigned this May 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 0.41%. Comparing base (5bf666e) to head (00d6de7).
Report is 12 commits behind head on develop.

Files Patch % Lines
src/Controller/Admin/LoginController.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             develop     #41      +/-   ##
============================================
- Coverage       0.42%   0.41%   -0.02%     
- Complexity       833     857      +24     
============================================
  Files            120     123       +3     
  Lines           3034    3162     +128     
============================================
  Hits              13      13              
- Misses          3021    3149     +128     
Flag Coverage Δ
8.3 0.41% <0.00%> (-0.02%) ⬇️
unittests 0.41% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turegjorup turegjorup merged commit b417f9a into develop May 3, 2024
7 checks passed
@turegjorup turegjorup deleted the feature/1284_url_path_updates branch May 3, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants