Feature/1601 ensure utc in database #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #46 +/- ##
============================================
- Coverage 0.40% 0.39% -0.02%
- Complexity 861 896 +35
============================================
Files 124 128 +4
Lines 3174 3260 +86
============================================
Hits 13 13
- Misses 3161 3247 +86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rimi-itk
approved these changes
Jun 10, 2024
src/Doctrine/Extensions/DBAL/Types/UTCDateTimeImmutableType.php
Outdated
Show resolved
Hide resolved
Comment on lines
+27
to
+34
| public const string VIEW_TIMEZONE = 'Europe/Copenhagen'; | ||
|
|
||
| // Default date time format used in the UI. | ||
| // | ||
| // @see https://unicode-org.github.io/icu/userguide/format_parse/datetime/#datetime-format-syntax | ||
| public const DATETIME_FORMAT = 'dd-MM-Y HH:mm:ss'; | ||
| public const string DATETIME_FORMAT = 'dd-MM-Y HH:mm:ss'; | ||
| public const string TIME_FORMAT = 'HH:mm:ss'; | ||
| public const string DATE_FORMAT = 'dd-MM-Y'; |
There was a problem hiding this comment.
Getting the “view” and “format” values from config (.env.local) would be really nice, but it may require a lot of effort.
There was a problem hiding this comment.
These are unlikely to change in the applications lifetime so will leave as is for now.
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/dashboard/show#/tickets/showTicket/1601
Description
Ensure all datetime fields are persisted as UTC in the database. See ADR 008 for background and discussion.
Screenshot of the result
N/A
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
If you have any further comments or questions for the reviewer please add them here.