Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1751: Refactor feed import to enable feed cleanup #48

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

turegjorup
Copy link
Contributor

Link to ticket

https://leantime.itkdev.dk/tickets/showKanban#/tickets/showTicket/1751

Description

  • Refactor feed import to allow cleanup of events
  • Split events in FeedItem and Event to better track errors and "last seen" data of events in feeds
  • Handle ``FeedItemData` synchronously when cleanup is active to allow for a delete strategy based on "last seen"

Screenshot of the result

If your change affects the user interface you should include a screenshot of the result with the pull request.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer please add them here.

@turegjorup turegjorup self-assigned this Sep 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 297 lines in your changes missing coverage. Please review.

Project coverage is 0.67%. Comparing base (929ae3a) to head (bce96ac).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/Command/Feed/FeedImportCommand.php 0.00% 55 Missing ⚠️
src/Entity/FeedItem.php 0.00% 51 Missing ⚠️
src/Service/Feeds/Reader/FeedReader.php 0.00% 47 Missing ⚠️
src/Entity/Feed.php 0.00% 28 Missing ⚠️
src/Repository/FeedItemRepository.php 0.00% 19 Missing ⚠️
src/MessageHandler/EventHandler.php 0.00% 16 Missing ⚠️
src/MessageHandler/FeedItemDataHandler.php 0.00% 16 Missing ⚠️
...rc/MessageHandler/FeedItemNormalizationHandler.php 0.00% 15 Missing ⚠️
src/Controller/Admin/FeedCrudController.php 0.00% 14 Missing ⚠️
src/Factory/EventFactory.php 0.00% 13 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff              @@
##             develop     #48      +/-   ##
============================================
- Coverage       0.70%   0.67%   -0.04%     
- Complexity       900     953      +53     
============================================
  Files            128     131       +3     
  Lines           3268    3431     +163     
============================================
  Hits              23      23              
- Misses          3245    3408     +163     
Flag Coverage Δ
8.3 0.67% <0.00%> (-0.04%) ⬇️
unittests 0.67% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turegjorup turegjorup merged commit 46d6e62 into develop Sep 13, 2024
7 checks passed
@turegjorup turegjorup deleted the feature/1751_cleanup_feed_events branch September 13, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants