Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORSLAG-76: Email and storage consent checkbox. Supporters export. #342

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

rimi-itk
Copy link
Contributor

@rimi-itk rimi-itk commented Aug 16, 2023

https://jira.itkdev.dk/browse/FORSLAG-76

Adds a custom “Supporters” view and uses a controller to display the view.

  • FORSLAG-76: Added email and storage consent checkbox (again!)
  • FORSLAG-76: Added custom proposal support view
  • FORSLAG-76: Added supporters controller

@rimi-itk rimi-itk requested review from martinyde and removed request for martinyde August 16, 2023 09:37
@rimi-itk rimi-itk marked this pull request as draft August 16, 2023 10:06
@rimi-itk rimi-itk force-pushed the feature/FORSLAG-76-support-mail branch from 549edbb to 4a75814 Compare August 16, 2023 12:01
@rimi-itk rimi-itk marked this pull request as ready for review August 16, 2023 12:04
@rimi-itk rimi-itk changed the title FORSLAG-76: Added email and storage consent checkbox on citizen proposal support form FORSLAG-76: Email and storage consent checkbox. Supporters export. Aug 16, 2023
Copy link
Contributor

@martinyde martinyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach with view_custom_table

@@ -2,3 +2,10 @@ hoeringsportal_citizen_proposal.admin:
title: 'Citizen proposal'
route_name: hoeringsportal_citizen_proposal.proposal_admin
base_route: system.admin_content

hoeringsportal_citizen_proposal.proposal_list:
# route_name: view.citizen_proposal_support.page_1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

@rimi-itk rimi-itk force-pushed the feature/FORSLAG-76-support-mail branch from 4a75814 to 6e99ebb Compare August 17, 2023 09:15
@rimi-itk rimi-itk force-pushed the feature/FORSLAG-76-support-mail branch from 6e99ebb to 0735a13 Compare August 17, 2023 09:16
@rimi-itk rimi-itk merged commit d0f9ae9 into develop Aug 17, 2023
10 checks passed
@rimi-itk rimi-itk deleted the feature/FORSLAG-76-support-mail branch August 17, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants