Feature/d 10 readiness

[martinyde]

https://jira.itkdev.dk/browse/HRIN-754

Preparing for d 10.

• Make custom modules and themes pass code analysis and compatible with d10
• Update contrib modules (Major versions):
  • better_exposed_filters
  • captcha
  • color_field
  • openid_connect
  • search_autocomplete
  • toolbar_visibility
  • twig_tweak
  • viewsreference

[rimi-itk]

Looks good.

We should go for just core_version_requirement: ^10 in custom modules to keep things clean.

[rimi-itk]

Approved with a comment.

[rimi-itk]

This code duplicates the PDF stuff above. Consider rewriting to

$extensions = ['pdf', 'docx'];
foreach ($extensions as $extension) {
  foreach (glob($document_source_path . '/*.' . $extension) as $document) {
    $destination = $this->fileSystem->copy($document, $document_target_path . '/' . basename($document), FileSystemInterface::EXISTS_REPLACE);
    $documents[] = $destination;
  }
}