Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed styling for search and main menu #378

Merged
merged 9 commits into from
Feb 5, 2024

Conversation

martinyde
Copy link
Contributor

@martinyde martinyde commented Jan 3, 2024

https://leantime.itkdev.dk/#/tickets/showTicket/131

  • Change search
  • Change main menu

Menu:
billede

Search results:
billede

@martinyde martinyde requested a review from yepzdk January 3, 2024 12:42
Copy link
Contributor

@yepzdk yepzdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple of minor comments in the code.

I regards to the design from the screenshots i have a couple of comments.

Menu:

  • It looks like the search icon hangs a bit low, and do not properly align with the menu items.

Search:

  • It looks like a border around the white background and not a shadow?
  • White background is also missing rounded corners.
  • Rounded corners is missing on the focused result.
  • The padding in the focused result seems a bit small, can we adjust
  • Can we limit the excerpt text to 2 lines?
  • Is it possible to highlight the part of the text that matches the query text, as en the design?
  • The spacing between the title and excerpt seems a bit too large.

@martinyde
Copy link
Contributor Author

Changed screenshots in description after changes.

Menu:

It looks like the search icon hangs a bit low, and do not properly align with the menu items.
--- Moved a bit up

Search:

It looks like a border around the white background and not a shadow?
--- Added shadow on top of border as design i think.

White background is also missing rounded corners.
--- Added rounded corners

Rounded corners is missing on the focused result.
--- Added rounded corners

The padding in the focused result seems a bit small, can we adjust
--- Changed badding from .5em to .75em
Can we limit the excerpt text to 2 lines?
--- Reduced text length.

Is it possible to highlight the part of the text that matches the query text, as en the design?
--- Added highlighting in header and excerpt (if found in the first two lines of the excerpt). The result excerpt cannot easily be created from the search query so we can't center the text around the search query.

The spacing between the title and excerpt seems a bit too large.
--- Removed spacing

@martinyde martinyde requested a review from yepzdk January 4, 2024 09:18
Base automatically changed from feature/drupal-10 to develop January 24, 2024 09:05
@martinyde martinyde merged commit 4158277 into develop Feb 5, 2024
11 checks passed
@martinyde martinyde deleted the feature/131-update-main-menu branch February 5, 2024 10:11
@rimi-itk rimi-itk mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants