-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed styling for search and main menu #378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yepzdk
reviewed
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A couple of minor comments in the code.
I regards to the design from the screenshots i have a couple of comments.
Menu:
- It looks like the search icon hangs a bit low, and do not properly align with the menu items.
Search:
- It looks like a border around the white background and not a shadow?
- White background is also missing rounded corners.
- Rounded corners is missing on the focused result.
- The padding in the focused result seems a bit small, can we adjust
- Can we limit the excerpt text to 2 lines?
- Is it possible to highlight the part of the text that matches the query text, as en the design?
- The spacing between the title and excerpt seems a bit too large.
web/themes/custom/hoeringsportal/assets/css/module/_search.scss
Outdated
Show resolved
Hide resolved
web/themes/custom/hoeringsportal/assets/css/module/_search.scss
Outdated
Show resolved
Hide resolved
Changed screenshots in description after changes. Menu:
Search:
|
yepzdk
approved these changes
Jan 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leantime.itkdev.dk/#/tickets/showTicket/131
Menu:
Search results: